[iOS11] Fix warnings #428
Merged
[iOS11] Fix warnings #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrettmoon
approved these changes
Nov 17, 2017
PINRemoteImage.podspec
Outdated
| @@ -76,7 +76,9 @@ Pod::Spec.new do |s| | |||
| s.subspec "PINCache" do |pc| | |||
| pc.dependency 'PINRemoteImage/Core' | |||
| pc.dependency 'PINCache', '=3.0.1-beta.6' | |||
| pc.osx.deployment_target = osx_deployment | |||
| pc.ios.deployment_target = ios_deployment | |||
There was a problem hiding this comment.
Super minor nit: mind fixing the spacing?
There was a problem hiding this comment.
no problem, will fix tomorrow morning. Thank you for review
…into warning-fixes
maicki
reviewed
Nov 20, 2017
| [self.session getAllTasksWithCompletionHandler:^(NSArray<__kindof NSURLSessionTask *> * _Nonnull tasks) { | ||
| concurrentDownloadsCompletion(tasks.count); | ||
| }]; | ||
| if (@available(macos 10.11, iOS 9.0, watchOS 2.0, tvOS 9.0, *)) { |
There was a problem hiding this comment.
@garrettmoon I remember we talked about not using @available to support Xcode < 9. Is this still the case?
There was a problem hiding this comment.
@maicki yeah, still shooting for that, but it'll be on top of this and will be a macro which uses @availabile on Xcode 9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I fixed some warnings in Xcode 9 and iOS 11. Also re-enabled iOS and tvOS support for
PINCacheinPINRemoteImage.podspec, i think it was disabled in #421 .After that PR was merged users got error(was reported in Texture slack channel too) :