Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Breaking Swift API] Use Fancy NSError Macros #440

Merged
merged 3 commits into from
Mar 13, 2018
Merged

[Breaking Swift API] Use Fancy NSError Macros #440

merged 3 commits into from
Mar 13, 2018

Conversation

Adlai-Holler
Copy link
Contributor

These improve the swift import. Currently they don't really do anything in Objective-C but never hurts to have.

maicki
maicki approved these changes Mar 10, 2018
View reviewed changes
Copy link
Collaborator

@maicki maicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

If it's breaking for Swift, we may should wait for a larger release?

@garrettmoon
Copy link
Collaborator

This is the time for breaking changes! We're in 3.0 beta period!

@Adlai-Holler Adlai-Holler merged commit db8d332 into master Mar 13, 2018
@maicki
Copy link
Collaborator

maicki commented Mar 13, 2018

Wise words.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maicki maicki maicki approved these changes

@garrettmoon garrettmoon Awaiting requested review from garrettmoon

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Adlai-Holler @garrettmoon @maicki