Set priority of download data tasks at the right time #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚫 CI failed with log |
…e the lib should do the right thing out of the box
nguyenhuy
commented
Feb 20, 2019
| @@ -18,7 +18,7 @@ typedef void (^PINRemoteImageDownloadCompletion)(NSURLResponse * _Nullable respo | |||
|
|
|||
| @interface PINRemoteImageDownloadQueue : NSObject | |||
|
|
|||
| @property (nonatomic, assign) NSUInteger maxNumberOfConcurrentDownloads; | |||
| @property (atomic, assign) NSUInteger maxNumberOfConcurrentDownloads; | |||
There was a problem hiding this comment.
This property is actually thread-safe so I thought it'd be a good idea to let clients know that.
|
🚫 CI failed with log |
nguyenhuy
commented
Feb 20, 2019
| NSURLSessionDataTask *dataTask = self->_progressImage.dataTask; | ||
| if (dataTask) { | ||
| dataTask.priority = dataTaskPriorityWithImageManagerPriority(priority); | ||
| [self.manager.urlSessionTaskQueue setQueuePriority:priority forTask:dataTask]; |
There was a problem hiding this comment.
No behavior change here, just cache the data task in a variable for better readability.
|
🚫 CI failed with log |
|
🚫 CI failed with log |
|
🚫 CI failed with log |
garrettmoon
approved these changes
Feb 20, 2019
maicki
approved these changes
Feb 20, 2019
| priority:priority | ||
| completionHandler:^(NSURLSessionTask *task, NSError *error) { | ||
| completionHandler(task.response, error); | ||
| [self lock]; |
There was a problem hiding this comment.
Do we need the indentation change here?
There was a problem hiding this comment.
The new priority param made this line too long so I break it into multiple lines hence the new indentation.
|
CI passed with build 625. |
|
Thanks for reviewing, @garrettmoon and @maicki. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the priority is set after a task has been scheduled and potentially sent off. It means the priority may not be picked up at all. This diff adds a new behavior that sets the priority right after the task is created.
Also expose an API that allows the priority to be set by Texture.