Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the PCH file and ensure macros are defined before using #556

Merged
merged 3 commits into from
Jul 2, 2020
Merged

Remove the PCH file and ensure macros are defined before using #556

merged 3 commits into from
Jul 2, 2020

Conversation

bolsinga
Copy link
Contributor

@bolsinga bolsinga commented Jul 2, 2020

No description provided.

@bolsinga bolsinga requested a review from garrettmoon July 2, 2020 20:02
garrettmoon
garrettmoon approved these changes Jul 2, 2020
View reviewed changes
Copy link
Collaborator

@garrettmoon garrettmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the Availability import need to go into macros?

@bolsinga
Copy link
Contributor Author

bolsinga commented Jul 2, 2020

Does the Availability import need to go into macros?

Good Q. I just had it import <Foundation/Foundation.h> to get it all settled.

@bolsinga bolsinga merged commit 50cb82d into pinterest:master Jul 2, 2020
@bolsinga bolsinga deleted the RemovePCHFile branch July 2, 2020 20:41
@bolsinga bolsinga mentioned this pull request Aug 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garrettmoon garrettmoon garrettmoon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bolsinga @garrettmoon