Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build error when using multiproject config #569

Merged
merged 1 commit into from
Oct 8, 2020

Conversation

hendych
Copy link
Contributor

@hendych hendych commented Sep 18, 2020

Fix path import to be compatible with multiple project config cocoapods

Warning: Switching your project to use multiple .xcodeproj may result in some compiler errors if your pods have relied on importing headers using the quote syntax for its dependencies. For example #import "PDDebugger.h" will no longer work in a pod that depends on PonyDebugger. Instead, we highly suggest you update your headers to correctly import the framework and its associated header: #import <PonyDebugger/PDDebugger.h>. This is intentional since this feature is currently opt-in.

Taken from: http://blog.cocoapods.org/CocoaPods-1.7.0-beta/

fixes #568

@Kaspik
Copy link

Kaspik commented Oct 5, 2020

@garrettmoon This is pretty serious issue for everyone using newer stuff on CocoaPods. Could we please ship 3.0.2 as this completely breaks the installation?

@garrettmoon
Copy link
Collaborator

@hendych would you mind rebasing and making sure all of the tests pass?

@Kaspik
Copy link

Kaspik commented Oct 7, 2020

@hendych Pretty please? :)

@hendych hendych force-pushed the fix/build-error-multiproject branch from fe161a4 to 2eb4464 Compare October 8, 2020 02:00
@hendych
Copy link
Contributor Author

hendych commented Oct 8, 2020

@Kaspik @garrettmoon Hi guys! all good and rebased. Sorry for the delay

@Kaspik
Copy link

Kaspik commented Oct 8, 2020

Perfect, thanks!

Copy link
Collaborator

@garrettmoon garrettmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@garrettmoon garrettmoon merged commit 99c5b9e into pinterest:master Oct 8, 2020
@hendych hendych deleted the fix/build-error-multiproject branch October 14, 2020 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken build using PINRemoteImage/WebP 3.0.1 when using :generate_multiple_pod_projects => true in Podfile
3 participants