Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPM - Objective-C++ consumers fix #573

Merged
merged 11 commits into from
Oct 6, 2020
Merged

SPM - Objective-C++ consumers fix #573

merged 11 commits into from
Oct 6, 2020

Conversation

3a4oT
Copy link
Contributor

@3a4oT 3a4oT commented Oct 6, 2020

Workaround for Objective-C++ module which will consume this package, otherwise - Use of '@import' when C++ modules are disabled, consider using -fmodules and -fcxx-modules. Texture is coming..

@3a4oT 3a4oT mentioned this pull request Oct 6, 2020
@3a4oT
Copy link
Contributor Author

3a4oT commented Oct 6, 2020

@garrettmoon I guess we need to change dependencies in Package.swift, currently it pointed to my fork instead of Pinterest repository. Will, you able to tag the new PINCache (3.0.2??) so I can point it to something like

.package(url: "https://github.com/pinterest/PINCache.git", from: "3.0.2")

@garrettmoon
Copy link
Collaborator

garrettmoon commented Oct 6, 2020

Wow, what a terrible code reviewer I am! Yes, please update to Pinterest and I'll publish a new release (working on it now).

@garrettmoon
Copy link
Collaborator

@garrettmoon I guess we need to change dependencies in Package.swift, currently it pointed to my fork instead of Pinterest repository. Will, you able to tag the new PINCache (3.0.2??) so I can point it to something like

.package(url: "https://github.com/pinterest/PINCache.git", from: "3.0.2")

3.0.2 is now available

@3a4oT
Copy link
Contributor Author

3a4oT commented Oct 6, 2020

@garrettmoon Awesome! Should be ready for review! Thanks!

Copy link
Collaborator

@garrettmoon garrettmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you for putting this up!

@garrettmoon garrettmoon merged commit 3587028 into pinterest:master Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants