-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPM - Objective-C++ consumers fix #573
Conversation
…Carthage and SPM jobs
# Conflicts: # Package.swift # Source/Classes/include/PINCache+PINRemoteImageCaching.h
@garrettmoon I guess we need to change dependencies in
|
Wow, what a terrible code reviewer I am! Yes, please update to Pinterest and I'll publish a new release (working on it now). |
3.0.2 is now available |
@garrettmoon Awesome! Should be ready for review! Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thank you for putting this up!
Workaround for Objective-C++ module which will consume this package, otherwise -
Use of '@import' when C++ modules are disabled, consider using -fmodules and -fcxx-modules
. Texture is coming..