Update Checkstyle regex to correctly parse line & char values from output #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying out the Checkstyle linter, I noticed that we sometimes weren't parsing out the correct line and character values. This then would cause the
ArcanistLintMessage
to point to the wrong spot in the code.For example, using the following example output:
[WARN] /some/path/to/file.java:49:8: Unused import - com.some.package.Class. [UnusedImports]
The existing regex would incorrectly believe
path
was/some/path/to/file.java:49
and the line number was8
. With the proposed pull request of making the regex lazy for thepath
grouping, we will then correctly havepath
be/some/path/to/file.java
, line number be49
, and character be8
.The canonical output of
[WARN] /some/path.java:123: Some message [etc]
is still parsed correctly.