Add PrettierESLintLinter #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we instead adjust the relative priorities of these two linters so they always run in a predictable order? |
jparise
reviewed
Mar 22, 2018
src/PrettierESLintLinter.php
Outdated
| echo $this->getProjectRoot() . '/' . $this->cwd; | ||
| list($err, $stdout, $stderr) = exec_manual('yarn -s --cwd %s which prettier-eslint', $this->getProjectRoot() . '/' . $this->cwd); | ||
| $binaryPath = strtok($stdout, "\n"); | ||
| echo $binaryPath; |
src/PrettierESLintLinter.php
Outdated
| } | ||
|
|
||
| public function getDefaultInterpreter() { | ||
| return __DIR__ . '/node4_proxy'; |
There was a problem hiding this comment.
Could this just be node with --harmony_array_includes as a mandatory flag?
I don't love shipping the helper script.
jparise
reviewed
Mar 22, 2018
| @@ -11,8 +11,8 @@ | |||
| 'class' => array( | |||
| 'ApacheThriftGeneratedLinter' => 'src/ApacheThriftGeneratedLinter.php', | |||
| 'ApacheThriftLinter' => 'src/ApacheThriftLinter.php', | |||
| 'PrettierLinter' => 'src/PrettierLinter.php', | |||
There was a problem hiding this comment.
Removed PrettierLinter by mistake?
CrabDude
force-pushed
the
master
branch
3 times, most recently
from
1c1150a
to
a8b0340
Compare
CrabDude
force-pushed
the
master
branch
3 times, most recently
from
97311a7
to
989ad4f
Compare
|
This is good to go. Includes 2 edge case fixes:
Includes 2 improvements:
|
jparise
approved these changes
Apr 12, 2018
src/PrettierESLintLinter.php
Outdated
| public function getDefaultBinary() { | ||
| list($err, $stdout, $stderr) = exec_manual('yarn -s --cwd %s which prettier-eslint', $this->getProjectRoot() . '/' . $this->cwd); | ||
| $binaryPath = strtok($stdout, "\n"); | ||
| if ($binaryPath == "") { |
There was a problem hiding this comment.
if (empty($binaryPath)) { is a little more idiomatic.
src/PrettierESLintLinter.php
Outdated
| $originalText = $this->getData($path); | ||
| $messages = array(); | ||
|
|
||
| // Ignored files have empty $stdout |
There was a problem hiding this comment.
Clarified.
// Note: $stdout is empty for ignored files
jhurwitz
added a commit
to jhurwitz/arcanist-linters
that referenced
this pull request
Oct 15, 2019
`$offense['ruleId'] || 'unknown'` was returning a bool (true) which caused the following exception when arc tried to post the lint results via the `harbormaster.sendmessage` API: ``` [2019-10-15 01:34:16] EXCEPTION: (ConduitClientException) ERR-CONDUIT-CORE: Parameter 'name' has invalid type. Expected type 'string', got type 'bool'. at [<phutil>/src/conduit/ConduitFuture.php:62] arcanist(head=master, ref.master=96fde137a1dc), linters(head=test, ref.master=81e8d886d5c8, ref.test=f20a8b42a357), phutil(head=master, ref.master=f434f57578dd) #0 <pinterest#2> ConduitFuture::didReceiveResult(array) called at [<phutil>/src/future/FutureProxy.php:58] pinterest#1 <pinterest#2> FutureProxy::getResult() called at [<phutil>/src/future/FutureProxy.php:35] pinterest#2 <pinterest#2> FutureProxy::resolve() called at [<arcanist>/src/workflow/ArcanistDiffWorkflow.php:2999] pinterest#3 phlog(ConduitClientException) called at [<arcanist>/src/workflow/ArcanistDiffWorkflow.php:3005] pinterest#4 ArcanistDiffWorkflow::updateAutotargets(string, NULL) called at [<arcanist>/src/workflow/ArcanistDiffWorkflow.php:537] pinterest#5 ArcanistDiffWorkflow::run() called at [<arcanist>/scripts/arcanist.php:394] ``` In these cases, `arc lint` and `arc diff` would successfully run, but the diff created on Phabricator would not show any details about what the lint errors/warnings were, or what line numbers they were on. With this fix, you can once again see the details of the lint errors and warnings in the Differential UI on Phabricator. I also changed the default name (when `$offense['ruleId']` is not defined) from `unknown` to `ESLintLinter`, and tested both cases: https://www.dropbox.com/s/0mb54bf5xfe34hi/Screenshot%202019-10-14%2019.20.51.png?dl=0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.