Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pasted from #80
When there are autofixable lint errors detected by eslint, the order of operations is:
arc diff
This means that
arc diff
fails to properly apply lint changes before creating a diff.See messages for a file provided by eslint@6.8.0
Summary of changes:
fix
fields in each message, and buildArcanistLintMessage
withoriginalText
andreplacementText
populated, along with a severity ofArcanistLintSeverity::SEVERITY_AUTOFIX
. This means that the user will receive a prompt asking if they'd like to apply the fixes.Remove theeslint.fix
flag because it likely causes more confusion that it helps.eslint.fix
flag to toggle this logic for backwards compatibility and as a way of gating these changes.