DNS protocol #21
Merged
DNS protocol #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
earlgreyz
force-pushed
the
dns
branch
2 times, most recently
from
27eae23
to
ad98508
Compare
|
Build failing because of #14 not merged |
|
that PR has been stuck for a year, shall we create a new PR with the same fix + tests? EDIT this makes no sense, the build is failing and there are no tests for thrift at all. I commented on the other PR |
|
@earlgreyz I just merged #14. |
jparise
reviewed
Jul 17, 2018
.travis.yml
Outdated
| @@ -1,6 +1,6 @@ | |||
| language: go | |||
| go: | |||
| - 1.7 | |||
| - 1.9 | |||
There was a problem hiding this comment.
Would you mind submitting this version bump separately to keep the commit history clean?
earlgreyz
force-pushed
the
dns
branch
2 times, most recently
from
6b321c6
to
b2c06c9
Compare
jparise
reviewed
Jul 17, 2018
|
@jparise I've updated the README mentioning the protocol, the DNS library and linking the |
|
Thanks for the contribution, @earlgreyz! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DNS loadtesting executor with a complete
TUTORIAL.mdto match already implemented protocols (thrift/http)