Validate SSL configuration before starting server #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If SSL certs are not available, then every SSL connection will fail. We should check for this condition at startup before opening the port. That way if a new node joins a cluster and its SSL configuration is not ready, it won't try to start accepting connections that could have gone to a healthy host.
|
Added a unit test. |
jparise
approved these changes
Nov 9, 2020
lib/thrift/binary/framed/server.ex
Outdated
| @@ -1,4 +1,6 @@ | |||
| defmodule Thrift.Binary.Framed.Server do | |||
| require Logger | |||
There was a problem hiding this comment.
I think this is now unused?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If SSL certs are not available, then every SSL connection will fail. We should
check for this condition at startup before opening the port. That way if a new
node joins a cluster and its SSL configuration is not ready, it won't try to
start accepting connections that could have gone to a healthy host.