New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace some Enum.map calls with for loops #79

Merged

jparise merged 1 commit into pinterest:thrift_tng from jparise:map-for

Dec 24, 2016

Collaborator

jparise commented Dec 24, 2016

We weren't using the Enum.map/2 results here so for loops are more
appropriate.


          Replace some Enum.map calls with for loops

202da05

We weren't using the Enum.map results here so for loops are more
appropriate.

jparise requested review from scohen and pguillory

December 24, 2016 20:20

ghost commented Dec 24, 2016

Ebert has finished reviewing this Pull Request and has found:

1 fixed issue! 🎉

You can see more details about this review at https://ebertapp.io/github/pinterest/elixir-thrift/pulls/79.

pguillory approved these changes

View reviewed changes

jparise merged commit 9a06255 into pinterest:thrift_tng

jparise deleted the map-for branch

December 24, 2016 20:47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment