Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coverall.io badge url; add test execution details #17

Merged
merged 1 commit into from
Jan 5, 2016

Conversation

linearregression
Copy link

  • Fix code coverage badge url
  • Add test execution detail show up on build. It is hard to tell which test failed

Add test execution detail show up on build. It is hard to tell which test failed
@@ -2,7 +2,7 @@ Elixometer
==========

[![Build Status](https://travis-ci.org/pinterest/elixometer.svg?branch=master)](https://travis-ci.org/pinterest/elixometer)
[![Coverage Status](https://coveralls.io/repos/pinterest/elixometer/badge.svg?branch=&service=github)](https://coveralls.io/github/pinterest/elixometer?branch=)
[![Coverage Status](https://coveralls.io/repos/pinterest/elixometer/badge.svg?branch=&service=github)](https://coveralls.io/github/pinterest/elixometer?branch=master)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this line also need to be branch=master?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now everything is master, so it may not matter.

If you decide to have a release branch for more stable code (or a develop branch to merge PR into first or something similar),
then it is better to be more specific.

jparise added a commit that referenced this pull request Jan 5, 2016
Fix coverall.io badge url; add test execution details
@jparise jparise merged commit 818e809 into pinterest:master Jan 5, 2016
@linearregression linearregression deleted the fix_badge_test branch January 5, 2016 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants