Removed exometer as a dependency #20
Conversation
| {:edown, github: "uwiger/edown", tag: "0.7", override: true}, | ||
| {:lager, github: "basho/lager", tag: "2.1.0", override: true}, | ||
| {:exometer, github: "pspdfkit-labs/exometer"}, | ||
| {:netlink, github: "Feuerlabs/netlink", ref: "d6e7188e", override: true}, | ||
| {:exometer_core, git: "git://github.com/PSPDFKit-labs/exometer_core.git", branch: "master"}, |
There was a problem hiding this comment.
Could you use {:exometer_core, github: "pspdfkit-labs/exometer_core"} here?
There was a problem hiding this comment.
I did, but this caused a conflict when I used this in our internal project; The conflict stems from exometer's rebar file using git://, while github in mix.exs causes it to use http as the protocol.
There was a problem hiding this comment.
That seems like a bug of some sort that should be addressed. But I'm glad there's a workaround.
There was a problem hiding this comment.
I'll ask in the elixir chat room if this is expected; I agree, they're the same repo (though the branch differed --exometer explicity required master... odd.
There was a problem hiding this comment.
Looks like there are several deps along the dependency chain (parse_trans, setup, etc.) that is calling edown all for a edoc generation. so far does not look like their code is calling anything in edown.
Also, there is a remove_deps.script in exometer/priv that looks like to prune the deps. But can't get that to work by rebar -C ...
For a otp release,you can exclude those out in reltool.config. Unsure how you can do it in mix (though there is a mix rebar plugin).
Also look at the network graph of the git repo. Lots just forked their own and remove the deps.
Lots of Erlang shops forked their own internally.
At this point, it does not seem to worth it. May be this is "an exercise left to the reader" to their post processing when they do otp release...unless you are willing to own the upstream dependencies.
|
👍 |
The community doesn't like having exometer as a dependency since most of the popular reporters are inside of exometer_core anyway. I removed it and cleaned up some of the other dependencies as well. Addresses pinterest#19
scohen
force-pushed
the
remove_exometer_dep
branch
from
99a1e83
to
f9e9c91
Compare
Removed exometer as a dependency
Using the current example in an application causes the following error: > You have configured application :exometer in your configuration > file but the application is not available. I think this is because pinterest#20 updated elixometer to depend on exometer_core instead of exometer, but did not update the README to configure exometer_core.
The community doesn't like having exometer as a dependency since most of
the popular reporters are inside of exometer_core anyway. I removed it
and cleaned up some of the other dependencies as well.
Addresses #19
@jparise