removed target so behavior matches current behavior

pinterest · Dec 18, 2020 · 4ab68e0 · 4ab68e0
1 parent 32f7e13
commit 4ab68e0
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 20 deletions.
diff --git a/packages/gestalt/src/Callout.js b/packages/gestalt/src/Callout.js
@@ -92,7 +92,6 @@ const CalloutAction = ({
           onClick={onClick}
           role="link"
           size="lg"
-          target="blank"
           text={label}
         />
       ) : (

diff --git a/packages/gestalt/src/Upsell.js b/packages/gestalt/src/Upsell.js
@@ -76,7 +76,6 @@ const UpsellAction = ({
           onClick={onClick}
           role="link"
           size="lg"
-          target="blank"
           text={label}
         />
       ) : (

diff --git a/packages/gestalt/src/__snapshots__/Callout.test.js.snap b/packages/gestalt/src/__snapshots__/Callout.test.js.snap
@@ -276,9 +276,9 @@ exports[`<Callout /> message + title + primaryAction + dismissButton 1`] = `
           onTouchEnd={[Function]}
           onTouchMove={[Function]}
           onTouchStart={[Function]}
-          rel="noopener noreferrer"
+          rel=""
           tabIndex={0}
-          target="_blank"
+          target={null}
         >
           <div
             className="Text fontSize3 darkGray alignCenter fontWeightBold"
@@ -424,9 +424,9 @@ exports[`<Callout /> message + title + primaryAction + secondaryAction 1`] = `
           onTouchEnd={[Function]}
           onTouchMove={[Function]}
           onTouchStart={[Function]}
-          rel="noopener noreferrer"
+          rel=""
           tabIndex={0}
-          target="_blank"
+          target={null}
         >
           <div
             className="Text fontSize3 darkGray alignCenter fontWeightBold"
@@ -454,9 +454,9 @@ exports[`<Callout /> message + title + primaryAction + secondaryAction 1`] = `
           onTouchEnd={[Function]}
           onTouchMove={[Function]}
           onTouchStart={[Function]}
-          rel="noopener noreferrer"
+          rel=""
           tabIndex={0}
-          target="_blank"
+          target={null}
         >
           <div
             className="Text fontSize3 darkGray alignCenter fontWeightBold"
@@ -557,9 +557,9 @@ exports[`<Callout /> message + title + primaryAction with href 1`] = `
           onTouchEnd={[Function]}
           onTouchMove={[Function]}
           onTouchStart={[Function]}
-          rel="noopener noreferrer"
+          rel=""
           tabIndex={0}
-          target="_blank"
+          target={null}
         >
           <div
             className="Text fontSize3 darkGray alignCenter fontWeightBold"

diff --git a/packages/gestalt/src/__snapshots__/Upsell.test.js.snap b/packages/gestalt/src/__snapshots__/Upsell.test.js.snap
@@ -138,9 +138,9 @@ exports[`<Upsell /> message + title + primaryAction + dismissButton + image 1`]
           onTouchEnd={[Function]}
           onTouchMove={[Function]}
           onTouchStart={[Function]}
-          rel="noopener noreferrer"
+          rel=""
           tabIndex={0}
-          target="_blank"
+          target={null}
         >
           <div
             className="Text fontSize3 white alignCenter fontWeightBold"
@@ -264,9 +264,9 @@ exports[`<Upsell /> message + title + primaryAction + dismissButton 1`] = `
           onTouchEnd={[Function]}
           onTouchMove={[Function]}
           onTouchStart={[Function]}
-          rel="noopener noreferrer"
+          rel=""
           tabIndex={0}
-          target="_blank"
+          target={null}
         >
           <div
             className="Text fontSize3 white alignCenter fontWeightBold"
@@ -390,9 +390,9 @@ exports[`<Upsell /> message + title + primaryAction + secondaryAction 1`] = `
           onTouchEnd={[Function]}
           onTouchMove={[Function]}
           onTouchStart={[Function]}
-          rel="noopener noreferrer"
+          rel=""
           tabIndex={0}
-          target="_blank"
+          target={null}
         >
           <div
             className="Text fontSize3 darkGray alignCenter fontWeightBold"
@@ -420,9 +420,9 @@ exports[`<Upsell /> message + title + primaryAction + secondaryAction 1`] = `
           onTouchEnd={[Function]}
           onTouchMove={[Function]}
           onTouchStart={[Function]}
-          rel="noopener noreferrer"
+          rel=""
           tabIndex={0}
-          target="_blank"
+          target={null}
         >
           <div
             className="Text fontSize3 white alignCenter fontWeightBold"
@@ -501,9 +501,9 @@ exports[`<Upsell /> message + title + primaryAction with href 1`] = `
           onTouchEnd={[Function]}
           onTouchMove={[Function]}
           onTouchStart={[Function]}
-          rel="noopener noreferrer"
+          rel=""
           tabIndex={0}
-          target="_blank"
+          target={null}
         >
           <div
             className="Text fontSize3 white alignCenter fontWeightBold"