fixes

pinterest · Sep 23, 2021 · 9282d99 · 9282d99
1 parent 0e6f9db
commit 9282d99
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 16 deletions.
diff --git a/cypress/integration/accessibility_Icon_spec.js b/cypress/integration/accessibility_Icon_spec.js
@@ -5,14 +5,14 @@ describe('Icon Accessibility check', () => {
   });
 
   it('Tests accessibility on the Icon page', () => {
-    cy.configureAxe({
-      rules: [
-        {
-          id: 'aria-command-name',
-          enabled: false,
-        },
-      ],
-    });
+    // cy.configureAxe({
+    //   rules: [
+    //     {
+    //       id: 'aria-command-name',
+    //       enabled: false,
+    //     },
+    //   ],
+    // });
 
     cy.checkA11y();
   });

diff --git a/cypress/integration/accessibility_Iconography and SVGs_spec.js b/cypress/integration/accessibility_Iconography and SVGs_spec.js
@@ -4,9 +4,7 @@ describe('Iconography and SVGs Accessibility check', () => {
     cy.injectAxe();
   });
 
-  // Disable the test for now since it's timing out on GitHub CI
-  // eslint-disable-next-line jest/no-disabled-tests
-  it.skip('Tests accessibility on the Iconography and SVGs page', () => {
+  it('Tests accessibility on the Iconography and SVGs page', () => {
     cy.checkA11y();
   });
 });
diff --git a/docs/pages/icon.js b/docs/pages/icon.js
@@ -87,9 +87,11 @@ export default function IconPage({ generatedDocGen }: {| generatedDocGen: DocGen
             type="don't"
             description="Don't create interactive Icons using TapArea. Use [IconButton](/iconbutton) instead."
             defaultCode={`
-<Tooltip text="Pinterest">
+<Tooltip text="Share pin">
   <TapArea>
-    <Icon icon="share" accessibilityLabel="" color="darkGray" />
+    <Box aria-hidden>
+      <Icon icon="share" accessibilityLabel="" color="darkGray" />
+    </Box>
   </TapArea>
 </Tooltip>`}
           />

diff --git a/docs/pages/iconography_and_svgs.js b/docs/pages/iconography_and_svgs.js
@@ -55,7 +55,7 @@ export default function IconPage(): Node {
             return undefined;
           }}
         >
-          <Box padding={2}>
+          <Box padding={2} aria-hidden>
             {/* $FlowFixMe[prop-missing] */}
             <Icon color="darkGray" accessibilityLabel="" icon={iconName} />
           </Box>

diff --git a/packages/gestalt/src/AvatarGroup.js b/packages/gestalt/src/AvatarGroup.js
@@ -16,9 +16,9 @@ type Size = 'xs' | 'sm' | 'md' | 'fit';
 type UnionRefs = HTMLDivElement | HTMLAnchorElement;
 type Props = {|
   /**
-   * Label for screen readers to announce Icon.
+   * Label for screen readers to announce AvatarGroup.
    *
-   * See the [Accessibility](#ARIA-attributes) guidelines for details on proper usage.
+   * See the [Accessibility guidelines](https://gestalt.pinterest.systems/AvatarGroup#Accessibility) for details on proper usage.
    */
   accessibilityLabel: string,
   /**