Dark mode: Fix ssr issue reloading the page when dark mode is enabled #1789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for gestalt ready! 🔨 Explore the source changes: 6c7b1a1 🔍 Inspect the deploy log: https://app.netlify.com/sites/gestalt/deploys/61a1ac16abefe70007b416f0 😎 Browse the preview: https://deploy-preview-1789--gestalt.netlify.app |
christianvuerings
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When dark mode is selected and the page is reloaded the ssr doesn't know the page is in dark mode so it ssr the page with light mode instead but the browser has dark mode so this makes a mistmatch and the UI doesn't have the correct colors.
This PR changes the way the dark mode value is stored to use cookies instead of local storage so the ssr can generate the page correctly whe dark mode is enabled.
Links
Checklist