Internal: Add CSS variables CI checks #1041
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves safety of our CSS variables.
We introduced a split CSS bundle for legacy and future CSS in #963 but this resulted in potential breakages:
Duplicate Variables with Different Values
We already saw this issue in #971 where the font-size variables for
Text
andHeading
got overridden resulting in heading sizes to be the same as text sizesTest: change a color that appears multiple times in 1 location:
to
CSS Variables in legacy CSS
This will break in IE11 since the compiled CSS will still contain the
var()
. We can only use:root
for now so it does get replaced in the legacy build.Test: Add this to any file CSS file