Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Fixed automatic detection for Fixed/CompositeZIndex imports in Codesandbox #1058

Merged
merged 1 commit into from Jul 20, 2020
Merged

Docs: Fixed automatic detection for Fixed/CompositeZIndex imports in Codesandbox #1058

merged 1 commit into from Jul 20, 2020

Conversation

AlbertCarreras
Copy link
Contributor

@AlbertCarreras AlbertCarreras commented Jul 20, 2020 •
edited

Docs: Fixed automatic detection for Fixed/CompositeZIndex imports in Codesandbox

##Before

image

##After
image

Test Plan

@AlbertCarreras AlbertCarreras requested a review from a team as a code owner July 20, 2020 17:40
@AlbertCarreras AlbertCarreras changed the title Docs: Fixed automatic detection Fixed/CompositeZIndex in Codesand Docs: Fixed automatic detection for Fixed/CompositeZIndex imports in Codesandbox Jul 20, 2020
@netlify
Copy link

netlify bot commented Jul 20, 2020 •
edited

Deploy preview for gestalt ready!

Built with commit d1c4e9f

https://deploy-preview-1058--gestalt.netlify.app

@christianvuerings christianvuerings added the patch release Patch release label Jul 20, 2020
@mergify mergify bot merged commit d8d2bb3 into pinterest:master Jul 20, 2020
@jackhsu978 jackhsu978 mentioned this pull request Jul 21, 2020
Merged
mergify bot pushed a commit that referenced this pull request Jul 21, 2020
@jackhsu978
Docs: fix broken CodeSandbox links (#1066)
290eedd 
This PR fixes CodeSandbox links in docs, which do not work since #1058

before
![Screenshot 2020-07-21 13 37 06](https://user-images.githubusercontent.com/5341184/88104865-ed2d8c80-cb57-11ea-89bf-ba3c051fa86e.png)

after
![Screenshot 2020-07-21 13 38 05](https://user-images.githubusercontent.com/5341184/88104880-f28ad700-cb57-11ea-9dca-284a9fd4796f.png)

## Test Plan

manually tested on localhost
@AlbertCarreras AlbertCarreras deleted the fixZindexDocs branch August 7, 2020 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianvuerings christianvuerings christianvuerings approved these changes

Assignees
No one assigned
Labels
patch release Patch release
Projects
None yet
Milestone
No milestone
2 participants
@AlbertCarreras @christianvuerings