Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal: disallow flow warnings #1127

Merged
merged 1 commit into from Aug 5, 2020
Merged

Internal: disallow flow warnings #1127

merged 1 commit into from Aug 5, 2020

Conversation

christianvuerings
Copy link
Contributor

We currently have 1 flow warning on master. We didn't catch this because we do allow warnings.
Screen Shot 2020-08-05 at 2 33 29 PM

Test Plan

CI checks pass

@christianvuerings christianvuerings requested a review from a team as a code owner August 5, 2020 21:34
@netlify
Copy link

netlify bot commented Aug 5, 2020

Deploy preview for gestalt ready!

Built with commit 8de7737

https://deploy-preview-1127--gestalt.netlify.app

@christianvuerings christianvuerings added the patch release Patch release label Aug 5, 2020
AlbertCarreras
AlbertCarreras approved these changes Aug 5, 2020
View reviewed changes
Copy link
Contributor

@AlbertCarreras AlbertCarreras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch

@christianvuerings christianvuerings merged commit 0e270a8 into pinterest:master Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlbertCarreras AlbertCarreras AlbertCarreras approved these changes

Assignees
No one assigned
Labels
patch release Patch release
Projects
None yet
Milestone
No milestone
2 participants
@christianvuerings @AlbertCarreras