New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: add sidebar alphabetization toggle #1154
Merged
christianvuerings
merged 4 commits into
pinterest:master
from
christianvuerings:alphabetize
Aug 21, 2020
Merged
Docs: add sidebar alphabetization toggle #1154
christianvuerings
merged 4 commits into
pinterest:master
from
christianvuerings:alphabetize
Aug 21, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mminute could you take a look and see if this also meets your use case? |
Deploy preview for gestalt ready! Built with commit 57554c0 |
docs/src/components/App.js
Outdated
export default function App(props: Props) { | ||
const { children } = props; | ||
const [isSidebarOpen, setIsSidebarOpen] = useState(false); | ||
const [colorScheme, setColorScheme] = useState('light'); | ||
|
||
useTracking('UA-12967896-44'); | ||
|
||
const [sidebarOrganisedBy, setSitebarOrganizedBy] = useState< |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo? setSidebarOrganizedBy
christianvuerings
force-pushed
the
alphabetize
branch
from
August 20, 2020 21:20
b4c125a
to
57554c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1128 from @mminute with the following changes:
localStorage
(so it stays consistent between refreshes)Getting Started
(more scalable but does mean we don't only sort components / hooks)Test Plan
Test on netlify: