Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal: Update backdrop wash to 80% opacity #1309

Merged
merged 3 commits into from Dec 14, 2020

Conversation

ayeshakmaz
Copy link
Contributor

Update Modal's Backdrop wash to 80% opacity black

  • added new var --g-colorTransparentGray800: rgba(0, 0, 0, 0.8);
  • Also changed the Mask wash to be 4% opacity to be consistent with mobile

Before:
Screen Shot 2020-12-09 at 2 24 25 PM

After:

Screen Shot 2020-12-09 at 2 24 34 PM

Test Plan

Manually verified visually

@ayeshakmaz ayeshakmaz requested a review from a team as a code owner December 9, 2020 22:29
@netlify
Copy link

netlify bot commented Dec 9, 2020

✔️ Deploy preview for gestalt ready!

🔨 Explore the source changes: 2eac892

🔍 Inspect the deploy logs: https://app.netlify.com/sites/gestalt/deploys/5fd2aaa0658389000790d85f

😎 Browse the preview: https://deploy-preview-1309--gestalt.netlify.app

@ajmoo
Copy link

ajmoo commented Dec 10, 2020

@ayeshakmaz looks like the background is set to the right color, but the whole thing is set to 90% opacity.

@ajmoo ajmoo self-requested a review December 11, 2020 23:34
Copy link

@ajmoo ajmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me

@AlbertCarreras AlbertCarreras added the minor release Minor release label Dec 14, 2020
@AlbertCarreras AlbertCarreras merged commit fcdc40c into pinterest:master Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor release Minor release
Projects
None yet
3 participants