ModuleExpandable: added external collapsing control (expandedIndex and onExpandedChange) #1323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy preview for gestalt ready! 🔨 Explore the source changes: 12e0c88 🔍 Inspect the deploy logs: https://app.netlify.com/sites/gestalt/deploys/60049889b420990007e816d6 😎 Browse the preview: https://deploy-preview-1323--gestalt.netlify.app |
AlbertCarreras
changed the title
galaxy0101
force-pushed
the
setExpandId
branch
from
6ac9a56
to
8ee0956
Compare
AlbertCarreras
changed the title
dangerismycat
requested changes
Jan 8, 2021
There was a problem hiding this comment.
Thanks for this PR! The team discussed your approach and various alternatives, and we think you're on the right track. I suggested some changes here to tighten up the API and implementation a bit. I haven't actually played around with this code, so please let me know if you run into any problems with this tweaked approach.
|
@galaxy0101 Here a few thoughts: https://www.loom.com/share/b2289b7eadab46ffab05d221b9379dc0 Code is here: #1341 |
galaxy0101
force-pushed
the
setExpandId
branch
from
bacc039
to
24f4f3e
Compare
AlbertCarreras
changed the title
AlbertCarreras
approved these changes
Jan 15, 2021
dangerismycat
requested changes
Jan 15, 2021
|
Sorry for the merge conflicts @galaxy0101 - looks like we were both working on Module |
galaxy0101
force-pushed
the
setExpandId
branch
from
585f8d8
to
12e0c88
Compare
dangerismycat
approved these changes
Jan 20, 2021
keyworks
pushed a commit
to keyworks/DefinitelyTyped
that referenced
this pull request
Mar 6, 2021
keyworks
pushed a commit
to keyworks/DefinitelyTyped
that referenced
this pull request
Mar 6, 2021
typescript-bot
pushed a commit
to DefinitelyTyped/DefinitelyTyped
that referenced
this pull request
Mar 9, 2021
* Add eye-hide icon (pinterest/gestalt#1337) * Add Module props and update Module.Expandable props (pinterest/gestalt#1323) * Add zIndex prop to Typeahead (pinterest/gestalt#1350) * Remove marginLeft and marginRight props in Box (pinterest/gestalt#1363) * Add onNavigation props to Provider/ActivationCard/Button/DropdownItem/IconButton/Link/TapArea (pinterest/gestalt#1364) * Add rel/target props to ActivationCard and ActionData (pinterest/gestalt#1384) * Add ScrollBoundaryContainer types (pinterest/gestalt#1394) * Add history icon * Add visit icon (pinterest/gestalt#1406) * Add type for Upsell.Form component (pinterest/gestalt#1396) * Add Jay Kim to definition owners * Fix lint errors * Add tests Co-authored-by: Jay Kim <jkim@pinterest.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ModuleExpandable: added external collapsing control (expandedIndex and onExpandedChange)
with Tests and Docs examples