[Internal] Add bundle size impact reporting #146
Conversation
|
Deploy preview for gestalt ready! Built with commit 6929552 |
|
Is it possible to use Danger for this? Facebook uses it for the same purpose: facebook/react#12682 (comment) Also, should we possibly be thinking of having a build matrix (dev/prod etc?) Uglify-es will strip all source-maps from the output. |
|
@chrislloyd yup, i don't see why not - i'll look into this!
Yup, happy to discuss this more. The way i set up the uglify plugin here was so that it would generate extra
I mainly did this to compare min+gzip size, but I think it would be a good idea to at least generate a minified umd build. |
|
Ah nice. Yeah - excited to see where you go with this :) |
liuyenwei
force-pushed
the
bundlesize
branch
23 times, most recently
from
45dd4d1
to
5a1c32d
Compare
Add api key buildkite-agent maybe?? shrug mount tmpfs and store stats there use temp sha apparently we have to pass buildnumber into artifact download buildkite artifact downloads using the exact path
liuyenwei
force-pushed
the
bundlesize
branch
2 times, most recently
from
08f5fb6
to
79ff8e9
Compare
liuyenwei
changed the title
| @@ -7,6 +7,16 @@ steps: | |||
| agents: | |||
| queue: elastic-builders | |||
| - wait | |||
| - name: ":hammer_and_wrench: build" | |||
There was a problem hiding this comment.
moved this here - the build is fast enough
liuyenwei
force-pushed
the
bundlesize
branch
5 times, most recently
from
c66affe
to
148b868
Compare
|
Glad you didn't add moment! |
This PR adds logic to our dangerfile to report on the bundle size impact of a PR. Currently this is only set as a warning, with the idea that whoever is reviewing the diff can easily see the bundle size impact. If no bundle size change was detected, nothing will be outputted.
The flow is:
stats.jsonartifact that was uploaded for ^ build.stats.jsonartifact for current buildExample of output (tested this by including
moment):