Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avatar, AvatarGroup, AvatarPair: Add usage guidelines #1624

Merged
merged 3 commits into from Aug 12, 2021

Conversation

ponori
Copy link
Contributor

@ponori ponori commented Aug 12, 2021

No description provided.

@ponori ponori requested a review from ayeshakmaz August 12, 2021 23:25
@ponori ponori requested a review from a team as a code owner August 12, 2021 23:25
@ponori ponori added the patch release Patch release label Aug 12, 2021
@ayeshakmaz ayeshakmaz self-assigned this Aug 12, 2021
@netlify
Copy link

netlify bot commented Aug 12, 2021

✔️ Deploy Preview for gestalt ready!

🔨 Explore the source changes: 4ae116e

🔍 Inspect the deploy log: https://app.netlify.com/sites/gestalt/deploys/6115b3eedc42f800071dc831

😎 Browse the preview: https://deploy-preview-1624--gestalt.netlify.app/

type="do"
title="When to Use"
description={`
- For the general display of groups of people, companies and/or brands.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably worth mentioning that this can also be used as a button to add more collaborators, which is unique to AvatarGroup

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call - I'll add!

title="When to Use"
description={`
- To represent a group of people, companies and/or brands in a square format.
- In cases where the parent element can represent either a single person/company or a group of people/companies.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I totally understand this one.... What does parent element refer to?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah... I'm having a hard time communicating this one. Basically, there are cases where UI will represent a individual account or a group of accounts in the same location (essentially, Inbox). I'm fumbling over how to best communicate this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds much better, love it!

@ayeshakmaz ayeshakmaz changed the title Added usage guidelines for Avatar, AvatarGroup and AvatarPair Avatar, AvatarGroup, AvatarPair: Added usage guidelines Aug 12, 2021
@ayeshakmaz ayeshakmaz changed the title Avatar, AvatarGroup, AvatarPair: Added usage guidelines Avatar, AvatarGroup, AvatarPair: Add usage guidelines Aug 12, 2021
Copy link
Contributor

@ayeshakmaz ayeshakmaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ponori ponori merged commit e46354a into master Aug 12, 2021
@ponori ponori deleted the pjo-avatar-usage-guidelines branch August 12, 2021 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch release Patch release
Projects
None yet
2 participants