New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avatar, AvatarGroup, AvatarPair: Add usage guidelines #1624
Conversation
✔️ Deploy Preview for gestalt ready! 🔨 Explore the source changes: 4ae116e 🔍 Inspect the deploy log: https://app.netlify.com/sites/gestalt/deploys/6115b3eedc42f800071dc831 😎 Browse the preview: https://deploy-preview-1624--gestalt.netlify.app/ |
type="do" | ||
title="When to Use" | ||
description={` | ||
- For the general display of groups of people, companies and/or brands. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably worth mentioning that this can also be used as a button to add more collaborators, which is unique to AvatarGroup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call - I'll add!
docs/src/AvatarPair.doc.js
Outdated
title="When to Use" | ||
description={` | ||
- To represent a group of people, companies and/or brands in a square format. | ||
- In cases where the parent element can represent either a single person/company or a group of people/companies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I totally understand this one.... What does parent element refer to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah... I'm having a hard time communicating this one. Basically, there are cases where UI will represent a individual account or a group of accounts in the same location (essentially, Inbox). I'm fumbling over how to best communicate this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sounds much better, love it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.