Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image: Add crossorigin property #1640

Merged
merged 2 commits into from Aug 24, 2021

Conversation

ayeshakmaz
Copy link
Contributor

Summary

Add ability to specify cross origin for Images

Checklist

  • Added unit and Flow Tests
  • Added documentation + accessibility tests
  • Verified accessibility: keyboard & screen reader interaction
  • Checked dark mode, responsiveness, and right-to-left support
  • Checked stakeholder feedback (e.g. Gestalt designers)

@ayeshakmaz ayeshakmaz added the minor release Minor release label Aug 19, 2021
@netlify
Copy link

netlify bot commented Aug 19, 2021

✔️ Deploy Preview for gestalt ready!

🔨 Explore the source changes: e003f98

🔍 Inspect the deploy log: https://app.netlify.com/sites/gestalt/deploys/612547ac8d5b720008c93d7e

😎 Browse the preview: https://deploy-preview-1640--gestalt.netlify.app

@ayeshakmaz ayeshakmaz marked this pull request as ready for review August 19, 2021 23:33
@ayeshakmaz ayeshakmaz requested a review from a team as a code owner August 19, 2021 23:33
packages/gestalt/src/Image.js Outdated Show resolved Hide resolved
packages/gestalt/src/Image.js Show resolved Hide resolved
@ayeshakmaz ayeshakmaz merged commit 95b99e6 into pinterest:master Aug 24, 2021
@ayeshakmaz ayeshakmaz deleted the ayesha/image-crossorigin branch August 24, 2021 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor release Minor release
Projects
None yet
2 participants