Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callout: use generated props table in docs #1705

Merged
merged 2 commits into from Sep 22, 2021

Conversation

dangerismycat
Copy link
Contributor

see title

@dangerismycat dangerismycat added the patch release Patch release label Sep 22, 2021
@netlify
Copy link

netlify bot commented Sep 22, 2021

✔️ Deploy Preview for gestalt ready!

🔨 Explore the source changes: aa298b8

🔍 Inspect the deploy log: https://app.netlify.com/sites/gestalt/deploys/614b79a03f79a60007d89104

😎 Browse the preview: https://deploy-preview-1705--gestalt.netlify.app

@dangerismycat dangerismycat marked this pull request as ready for review September 22, 2021 02:00
@dangerismycat dangerismycat requested a review from a team as a code owner September 22, 2021 02:00
<PageHeader
name="Callout"
description={`
export default function SearchFieldPage({ generatedDocGen }: {| generatedDocGen: DocGen |}): Node {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CalloutPage

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

primaryAction?: ActionDataType,
secondaryAction?: ActionDataType,
/**
* Main action for users to take on Upsell. If `href` is supplied, the action will serve as a link. See [OnLinkNavigationProvider](https://gestalt.pinterest.systems/callout/OnLinkNavigationProvider) to learn more about link navigation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main action for users to take on Callout

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is currently in the docs 😱 🤦‍♂️

target?: null | 'self' | 'blank',
|},
/**
* Secondary action for users to take on Upsell. If `href` is supplied, the action will serve as a link. See [OnLinkNavigationProvider](https://gestalt.pinterest.systems/callout/OnLinkNavigationProvider) to learn more about link navigation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Secondary action for users to take on Callout

Copy link
Contributor

@AlbertCarreras AlbertCarreras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dangerismycat dangerismycat merged commit 900d2ac into pinterest:master Sep 22, 2021
@dangerismycat dangerismycat deleted the callout-docs-updates branch September 22, 2021 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch release Patch release
Projects
None yet
2 participants