New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Callout: use generated props table in docs #1705
Callout: use generated props table in docs #1705
Conversation
✔️ Deploy Preview for gestalt ready! 🔨 Explore the source changes: aa298b8 🔍 Inspect the deploy log: https://app.netlify.com/sites/gestalt/deploys/614b79a03f79a60007d89104 😎 Browse the preview: https://deploy-preview-1705--gestalt.netlify.app |
docs/pages/callout.js
Outdated
<PageHeader | ||
name="Callout" | ||
description={` | ||
export default function SearchFieldPage({ generatedDocGen }: {| generatedDocGen: DocGen |}): Node { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CalloutPage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch!
packages/gestalt/src/Callout.js
Outdated
primaryAction?: ActionDataType, | ||
secondaryAction?: ActionDataType, | ||
/** | ||
* Main action for users to take on Upsell. If `href` is supplied, the action will serve as a link. See [OnLinkNavigationProvider](https://gestalt.pinterest.systems/callout/OnLinkNavigationProvider) to learn more about link navigation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Main action for users to take on Callout
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is currently in the docs 😱 🤦♂️
packages/gestalt/src/Callout.js
Outdated
target?: null | 'self' | 'blank', | ||
|}, | ||
/** | ||
* Secondary action for users to take on Upsell. If `href` is supplied, the action will serve as a link. See [OnLinkNavigationProvider](https://gestalt.pinterest.systems/callout/OnLinkNavigationProvider) to learn more about link navigation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Secondary action for users to take on Callout
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
see title