Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown, Module, Table: use autogen descriptions for subcomponents #1950

Merged
merged 1 commit into from Feb 22, 2022

Conversation

dangerismycat
Copy link
Contributor

This PR add MainSection.Subsections around the subcomponent props table, surfacing the subcomponent descriptions.

@dangerismycat dangerismycat added the patch release Patch release label Feb 18, 2022
@netlify
Copy link

netlify bot commented Feb 19, 2022

✔️ Deploy Preview for gestalt ready!

🔨 Explore the source changes: b092ff0

🔍 Inspect the deploy log: https://app.netlify.com/sites/gestalt/deploys/6210322d34353f00086bdd0f

😎 Browse the preview: https://deploy-preview-1950--gestalt.netlify.app

@AlbertCarreras AlbertCarreras marked this pull request as ready for review February 22, 2022 10:00
@AlbertCarreras AlbertCarreras requested a review from a team as a code owner February 22, 2022 10:00
@AlbertCarreras
Copy link
Contributor

It was a draft, but it looked all good to me. I'm gonna approve in case you wanna merge. I wonder if some snapshots might change with changes in the display name.

Copy link
Contributor

@AlbertCarreras AlbertCarreras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dangerismycat dangerismycat merged commit 4f840d7 into pinterest:master Feb 22, 2022
@dangerismycat dangerismycat deleted the subcomponent-metadata branch February 22, 2022 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch release Patch release
Projects
None yet
2 participants