Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal: Bump peer dependencies to support React 18 #2069

Merged
merged 1 commit into from Apr 14, 2022

Conversation

liuyenwei
Copy link
Contributor

Summary

Updates the react/react-dom peer dependencies for gestalt and gestalt-datepicker to support 18.x. We currently aren't leveraging any React 18 specific APIs so this change is safe. In the future, if we start using some of the React 18 APIs, we'll need to think about backwards compatibility or dropping support for older versions of React.

Note: this does not update the React version for docs.

@liuyenwei liuyenwei added the dependencies Pull requests that update a dependency file label Apr 14, 2022
@liuyenwei liuyenwei requested a review from a team as a code owner April 14, 2022 00:44
@netlify
Copy link

netlify bot commented Apr 14, 2022

Deploy Preview for gestalt ready!

Name Link
🔨 Latest commit 4e605d5
🔍 Latest deploy log https://app.netlify.com/sites/gestalt/deploys/62576e8137ab3d0008dfd294
😎 Deploy Preview https://deploy-preview-2069--gestalt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 14, 2022

Deploy Preview for gestalt ready!

Name Link
🔨 Latest commit fd0e159
🔍 Latest deploy log https://app.netlify.com/sites/gestalt/deploys/62576ff7d688890009cc5e15
😎 Deploy Preview https://deploy-preview-2069--gestalt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@liuyenwei liuyenwei added the patch release Patch release label Apr 14, 2022
Copy link
Contributor

@AlbertCarreras AlbertCarreras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@AlbertCarreras AlbertCarreras merged commit 183fb4b into pinterest:master Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file patch release Patch release
Projects
None yet
2 participants