Add onKeyDown to TextField and TextArea #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for gestalt ready! Built with commit 4d83201 |
Generated by 🚫 dangerJS |
jennyscript
force-pushed
the
add-keydown-textarea
branch
from
1a2afb4
to
fe93cab
Compare
jennyscript
force-pushed
the
add-keydown-textarea
branch
from
75f4993
to
96e3ca2
Compare
btraut
approved these changes
Aug 19, 2018
pfarejowicz
reviewed
Aug 19, 2018
| @@ -44,16 +44,24 @@ card( | |||
| }, | |||
| { | |||
| name: 'onBlur', | |||
| type: '({ event: SyntheticFocusEvent<>, value: string }) => void', | |||
| type: | |||
There was a problem hiding this comment.
These are going to cause Flow errors when bumping in pinboard - prepare yourselves, winter is coming
| handleChange = (event: SyntheticInputEvent<HTMLTextAreaElement>) => { | ||
| this.props.onChange({ | ||
| event, | ||
| value: event.currentTarget.value, |
There was a problem hiding this comment.
are we sure this is the same, event.target.value and event.currentTarget.value? i know there was once a currentTarget target change in pinboard and it caused a rollback/hotfix
christianvuerings
approved these changes
Aug 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.