Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button: Fix transparent button on blue background #316

Merged

Conversation

christianvuerings
Copy link
Contributor

Before:
screen shot 2018-08-27 at 10 15 47 am

After:
screen shot 2018-08-27 at 10 15 54 am

@christianvuerings
Copy link
Contributor Author

Deploy preview for gestalt ready!

Built with commit 09500f0

https://deploy-preview-316--gestalt.netlify.com

@ghost
Copy link

ghost commented Aug 27, 2018

Warnings
⚠️

📁 Bundlesize - Bundle size increase detected, please review

Filename Size Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip
gestalt.css 🔺 0.0% 🔻 0.1% 53.18 KB 53.2 KB 8.96 KB 8.96 KB

Generated by 🚫 dangerJS

Copy link
Contributor

@pfarejowicz pfarejowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for both blue and darkGray backgrounds on netlify

@christianvuerings christianvuerings merged commit a5d2eed into pinterest:master Aug 27, 2018
@christianvuerings christianvuerings deleted the fix-transparent-button branch August 27, 2018 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants