Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue introduced by #3544 that was causing overlapping positions in the
defaultTwoColumnModuleLayout
when a multi column item was rendered towards the end of the first page.The overlap happens in the situation when
initializeHeightsArray
is called and the following is true:i.e.
[A, B, C, D, E, F, G] - assuming E is the multi column item and the layout looks like:
| A | B | C |
| D | F | G |
| _ | E | E |
In this scenario, the current logic will think that the column height for column 1, 2 are B + E and C + E respectively.
Fix
This PR fixes this scenario by simplifying the logic. Ultimately, the height of each column is determine by the lowest position module in that column so we can change this to just be:
(for each item):
Test Plan
Tested this in pinboard - I managed to find an example that consistently repro'd
Also added unit tests around the heights logic using the same repro ^