Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal: remove .flowtest.js #3566

Merged
merged 1 commit into from
May 14, 2024

Conversation

jackhsu978
Copy link
Member

What changed?

All .flowtest.js files are removed

Why?

Most (if not all) tests in .flowtest.js files can be replaced by Flow and unit tests, so they provide little values. We are removing them now to make TypeScript migration simpler.

@jackhsu978 jackhsu978 added the patch release Patch release label May 14, 2024
@jackhsu978 jackhsu978 requested a review from a team as a code owner May 14, 2024 17:29
Copy link

netlify bot commented May 14, 2024

Deploy Preview for gestalt ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit c2b892e
🔍 Latest deploy log https://app.netlify.com/sites/gestalt/deploys/66439f602a57710008e0f67b
😎 Deploy Preview https://deploy-preview-3566--gestalt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jackhsu978 jackhsu978 merged commit 96affa0 into pinterest:master May 14, 2024
15 checks passed
@jackhsu978 jackhsu978 deleted the remove-flowtest branch May 21, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch release Patch release
Projects
None yet
2 participants