Upgrade to flow v0.69.0 #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrislloyd
reviewed
Apr 10, 2019
packages/gestalt/src/Contents.js
Outdated
| @@ -371,7 +371,7 @@ export default class Contents extends React.Component<Props, State> { | |||
| mainDir: null, | |||
| }; | |||
|
|
|||
| flyout = React.createRef(); | |||
| flyout: {| current: null | HTMLDivElement |} = React.createRef(); | |||
There was a problem hiding this comment.
This is such a weird type - it would feel way more natural to do something like flyout = React.createRef<HTMLDivElement>(); but obviously what do I know.
chrislloyd
approved these changes
Apr 10, 2019
pfarejowicz
approved these changes
Apr 10, 2019
packages/gestalt/src/Contents.js
Outdated
| @@ -371,7 +371,7 @@ export default class Contents extends React.Component<Props, State> { | |||
| mainDir: null, | |||
| }; | |||
|
|
|||
| flyout = React.createRef(); | |||
| flyout: {| current: null | HTMLDivElement |} = React.createRef(); | |||
There was a problem hiding this comment.
agree we dont have a nice polymorphic type, but can we use React.ElementRef maybe?
facebook/flow@d74ab13
https://flow.org/en/docs/react/types/#toc-react-elementref
packages/gestalt/src/Tooltip.js
Outdated
| @@ -22,7 +22,7 @@ export default class Tooltip extends React.Component<Props, State> { | |||
| hovered: false, | |||
| }; | |||
|
|
|||
| childRef = React.createRef(); | |||
| childRef: {| current: null | HTMLDivElement |} = React.createRef(); | |||
There was a problem hiding this comment.
same here, React.ElementRef?
pfarejowicz
approved these changes
Apr 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/facebook/flow/releases/tag/v0.96.0