Disabled IconButton states #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 9, 2019 10:40
btraut
reviewed
May 9, 2019
| background: transparent; | ||
| } | ||
|
|
||
| .enabled { |
There was a problem hiding this comment.
Tiny nit: I'm not sure how the rest of Gestalt does it, but in past projects, I tended to include the default case (enabled, in this case) along with the base styles, and then use the alternate (disabled) state as overrides. Otherwise the component isn't truly "styled" until you add either an enabled or disabled style, and the code doesn't communicate this well.
There was a problem hiding this comment.
I tried pulling the pointer back into the base styles and only adding the disabled one when the prop is set but it doesnt work. The base styles always override this one. Im going to keep it as is since thats what Button.js does
btraut
reviewed
May 9, 2019
packages/gestalt/src/IconButton.js
Outdated
| @@ -93,10 +101,10 @@ export default class IconButton extends React.Component<Props, State> { | |||
| type="button" | |||
| > | |||
| <Pog | |||
| active={active} | |||
| active={disabled ? false : active} | |||
btraut
approved these changes
May 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop gap solution to introduce
disabledprop to<IconButton />until we get a more cohesive unified solution to buttons.