Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new icon svgs #522

Merged
merged 1 commit into from May 14, 2019
Merged

Conversation

ZaphyrRobin
Copy link
Contributor

@ZaphyrRobin ZaphyrRobin commented May 14, 2019

Add new icon SVG images 'ads-stats' and 'ads-overview'
Screen Shot 2019-05-14 at 9 55 51 AM

Screen Shot 2019-05-14 at 9 56 23 AM

  • Documentation add new icon svgs

@ZaphyrRobin ZaphyrRobin requested a review from a team as a code owner May 14, 2019 16:57
@@ -0,0 +1 @@
<svg height="24" viewBox="0 0 24 24" width="24" xmlns="http://www.w3.org/2000/svg"><path d="m2.5 19c-.828 0-1.5.672-1.5 1.5s.672 1.5 1.5 1.5 1.5-.672 1.5-1.5-.672-1.5-1.5-1.5m19 0h-14c-.829 0-1.5.671-1.5 1.5s.671 1.5 1.5 1.5h14c.829 0 1.5-.671 1.5-1.5s-.671-1.5-1.5-1.5m-19-5c-.828 0-1.5.672-1.5 1.5s.672 1.5 1.5 1.5 1.5-.672 1.5-1.5-.672-1.5-1.5-1.5m19 0h-14c-.829 0-1.5.671-1.5 1.5s.671 1.5 1.5 1.5h14c.829 0 1.5-.671 1.5-1.5s-.671-1.5-1.5-1.5m-11.5-3h4c.552 0 1-.448 1-1v-7c0-.552-.448-1-1-1h-4c-.552 0-1 .448-1 1v7c0 .552.448 1 1 1m12-9h-4c-.552 0-1 .448-1 1v7c0 .552.448 1 1 1h4c.552 0 1-.448 1-1v-7c0-.552-.448-1-1-1m-21 8v-7c0-.552.448-1 1-1h4c.552 0 1 .448 1 1v7c0 .552-.448 1-1 1h-4c-.552 0-1-.448-1-1" fill="#8e8e8e" fill-rule="evenodd"/></svg>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are not optimized and compressed, running it through svgo yields a 30% reduction in size
image

Did these come from PDS, they should be providing optimized ones

Copy link
Contributor

@pfarejowicz pfarejowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@pfarejowicz pfarejowicz merged commit 48c4cfa into pinterest:master May 14, 2019
@ZaphyrRobin ZaphyrRobin deleted the feature-branch branch May 14, 2019 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants