Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltip: Add idealDirection #701

Merged
merged 1 commit into from Feb 28, 2020
Merged

Tooltip: Add idealDirection #701

merged 1 commit into from Feb 28, 2020

Conversation

ZaphyrRobin
Copy link
Contributor

Minor

Screen Shot 2020-02-27 at 2 49 18 PM

Screen Shot 2020-02-27 at 2 51 38 PM

@ZaphyrRobin ZaphyrRobin requested a review from a team as a code owner February 27, 2020 22:53
christianvuerings
christianvuerings reviewed Feb 27, 2020
View reviewed changes
CHANGELOG.md Outdated
@@ -8,17 +8,21 @@

### Minor

- Add idealDirection to Tooltip and IconWithTooltip (#697)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ZaphyrRobin Can we add it only to Tooltip, IconWithTooltip is deprecated since we'll add link to Tooltip in #684

Also, change the description to Tooltip: Add idealDirection

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, thanks!

@ZaphyrRobin ZaphyrRobin changed the title Add idealDirection to tooltip and iconWithTooltip (#697) Add idealDirection to tooltip and iconWithTooltip (#701) Feb 28, 2020
@ZaphyrRobin ZaphyrRobin changed the title Add idealDirection to tooltip and iconWithTooltip (#701) Add idealDirection to tooltip and iconWithTooltip Feb 28, 2020
@christianvuerings christianvuerings changed the title Add idealDirection to tooltip and iconWithTooltip Tooltip: Add idealDirection Feb 28, 2020
@christianvuerings christianvuerings merged commit 9b1e85d into pinterest:master Feb 28, 2020
@christianvuerings christianvuerings mentioned this pull request Feb 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianvuerings christianvuerings christianvuerings approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ZaphyrRobin @christianvuerings