Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flyout: Responsive, updated sizes + minimum width #743

Merged
merged 1 commit into from Mar 16, 2020
Merged

Flyout: Responsive, updated sizes + minimum width #743

merged 1 commit into from Mar 16, 2020

Conversation

christianvuerings
Copy link
Contributor

@christianvuerings christianvuerings commented Mar 11, 2020 •
edited

Makes Flyout responsive between 180px and the specified width. It's especially nice for for flyouts that don't have that much content.

flyout-responsive-before-after

Notes

  • Doesn't make changes to Tooltip - in that case width is set to null so we don't apply minDimensions

@christianvuerings christianvuerings requested a review from a team as a code owner March 11, 2020 21:29
dangerismycat
dangerismycat approved these changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@dangerismycat dangerismycat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for this!

@christianvuerings christianvuerings merged commit 6194f7f into pinterest:master Mar 16, 2020
@christianvuerings christianvuerings mentioned this pull request Mar 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btraut btraut btraut approved these changes

@jennyscript jennyscript jennyscript approved these changes

@dangerismycat dangerismycat dangerismycat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@christianvuerings @btraut @jennyscript @dangerismycat