Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal: enable + enforce flow strict on every file #841

Merged
merged 1 commit into from May 5, 2020
Merged

Internal: enable + enforce flow strict on every file #841

merged 1 commit into from May 5, 2020

Conversation

christianvuerings
Copy link
Contributor

@christianvuerings christianvuerings commented May 5, 2020 •
edited

Flow Strict

enable stronger safety guarantees in Flow (such as banning any/Object/Function types and requiring all dependencies to be typed)

Changes:

  • Enabled flow strict for every file
  • Add linter so we don't regress

Allows other repositories to use Gestalt in Flow strict mode.

@christianvuerings christianvuerings requested a review from a team as a code owner May 5, 2020 15:10
jennyscript
jennyscript approved these changes May 5, 2020
View reviewed changes
Copy link
Member

@jennyscript jennyscript left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this!

@christianvuerings christianvuerings merged commit 2de1d88 into pinterest:master May 5, 2020
@christianvuerings christianvuerings mentioned this pull request May 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennyscript jennyscript jennyscript approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@christianvuerings @jennyscript