property-naming flags extension properties

[vanniktech]

The following code gets flagged with 0.49.1:

val Context.adsDelegateFactory @SuppressLint("WrongConstant") get() =
  applicationContext.getSystemService(SYSTEM_SERVICE_AD_DELEGATE_FACTORY) as AdsDelegateFactory

Property name should use the screaming snake case notation when the value can not be changed (standard:property-naming)

I would not expect this, if you're adding a property via an extension and leveraging get() since the value can indeed change inside the implementation.

[vanniktech]

So when I remove @SuppressLint("WrongConstant") it does not get flagged as expected. So there's something weird going on.

[paul-dingemans]

Indeed, the annotation causes the check to fail. Same happens with:

val Context.adsDelegateFactory private get() =
    applicationContext.getSystemService(SYSTEM_SERVICE_AD_DELEGATE_FACTORY) as AdsDelegateFactory

[paul-dingemans]

Problem will either be resolved in 0.49.2 only when more pressing bugs need to be fixed. Otherwise it will be fixed in the next normal release.