Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix snapshot publishing #1009

Merged
merged 1 commit into from
Dec 13, 2020
Merged

Conversation

romtsn
Copy link
Collaborator

@romtsn romtsn commented Dec 13, 2020

According to johnrengelman/shadow#586 the fat jar is now automatically published, so we do not need to specify it explicitly (this was causing the issue of multiple artifacts with the same classifier). Tested locally with publishToMavenLocal task.

@shashachu
Copy link
Contributor

Looks fine to fix publishing but let's keep an eye on the original issue, as some people consider it a bug so it's possible the behavior will be reverted.

@shashachu shashachu merged commit 7983445 into pinterest:master Dec 13, 2020
@romtsn romtsn deleted the fix/snapshot-publishing branch December 13, 2020 17:32
romtsn added a commit to paul-dingemans/ktlint that referenced this pull request Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants