Change the loglevel of the provided logger only when it is the Logback logger #1425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k logger For non-Logback loggers, it is only checked whether the enabled log level of the provided logger, is matching with the loglevel that Ktlint expects based on settings. Currently, only the Logback Classic logger (ch.qos.logback.classic.Logger) allows to change it loglevel dynamically. Closes pinterest#1421
|
Close in favor of #1424 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the loglevel of the provided logger only when it is the Logback logger
For non-Logback loggers, it is only checked whether the enabled log level
of the provided logger, is matching with the loglevel that Ktlint expects
based on settings.
Currently, only the Logback Classic logger (ch.qos.logback.classic.Logger)
allows to change it loglevel dynamically.
Closes #1421
Checklist
CHANGELOG.mdis updatedIn case of adding a new rule:
README.mdis updated