Newline inside value argument should not trigger trailing comma rule #1648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er is only found inside a multiline argument. Only in case a newline character is found between arguments, this should be taken into account to add a trailing comma. * Refactor and cleanup unused branches in isMultiline method Closes pinterest#1642
paul-dingemans
deleted the
1642-no-trailing-comma-for-multiline-argument
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Do not add a trailing comma in a function call if a newline character is only found inside a multiline argument. Only in case a newline character is found between arguments, this should be taken into account to add a trailing comma.
Refactor and cleanup unused branches in isMultiline method
Closes #1642
Checklist
CHANGELOG.mdis updatedIn case of adding a new rule: