Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not wrap a binary expression after an elvis operator #2134

Merged
merged 2 commits into from
Jul 16, 2023

Conversation

paul-dingemans
Copy link
Collaborator

Description

Do not wrap a binary expression after an elvis operator in case the max line length is exceeded

Use sets internally in KtlintAssertThat rather than lists for storage and comparing of LintViolations. Like the KtlintRuleEngine duplicate violations are to be ignored.

Closes #2128

Checklist

Before submitting the PR, please check following (checks which are not relevant may be ignored):

  • Commit message are well written. In addition to a short title, the commit message also explain why a change is made.
  • At least one commit message contains a reference Closes #<xxx> or Fixes #<xxx> (replace<xxx> with issue number)
  • Tests are added
  • KtLint format has been applied on source code itself and violations are fixed
  • CHANGELOG.md is updated
  • PR description added

Documentation is updated. See difference between snapshot and release documentation

…ax line length is exceeded

Use sets internally in KtlintAssertThat rather than lists for storage and comparing of LintViolations. Like the KtlintRuleEngine duplicate violations are to be ignored.

Closes #2128
@paul-dingemans paul-dingemans merged commit dd45e41 into master Jul 16, 2023
16 checks passed
@paul-dingemans paul-dingemans deleted the 2128-binary-expression-wrapping branch July 16, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Endless loop in wrapping binary expression after elvis operator
1 participant