Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and align Maven coordinates #2195

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Conversation

paul-dingemans
Copy link
Collaborator

Description

Closes #1931

Checklist

Before submitting the PR, please check following (checks which are not relevant may be ignored):

  • Commit message are well written. In addition to a short title, the commit message also explain why a change is made.
  • At least one commit message contains a reference Closes #<xxx> or Fixes #<xxx> (replace<xxx> with issue number)
  • Tests are added
  • KtLint format has been applied on source code itself and violations are fixed
  • CHANGELOG.md is updated
  • PR description added

Documentation is updated. See difference between snapshot and release documentation

@Goooler
Copy link
Contributor

Goooler commented Aug 23, 2023

In this change, do we need to update the version to 1.0.0-snapshot?

VERSION_NAME=0.50.1-SNAPSHOT

@paul-dingemans paul-dingemans merged commit a7713b0 into master Aug 23, 2023
22 checks passed
@paul-dingemans paul-dingemans deleted the 1931-fix-maven-coordinates branch August 23, 2023 18:42

| Old Maven coordinates | New Maven coordinates |
|----------------------------------------------------|--------------------------------------------------------|
| com.pinterest.ktlint | com.pinterest.ktlint.ktlint-cli |
Copy link
Contributor

@PaulWoitaschek PaulWoitaschek Sep 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the coordinates are actually with a double colon:

I.e.
com.pinterest:ktlint -> com.pinterest.ktlint:ktlint-cli

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tnx. Fixed via #2264

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correct the maven coordinates in version 1.0
3 participants