2550 clikt #2556
Merged
2550 clikt #2556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Janino is required for logback-test.xml conditional configuration so that trace-logging in unit test can be automatically enabled using an environment variable This (partially) reverts commit a6e6b55.
Clikt is a kotlin library which allows more Kotlin native code. Also, it is blocking minifying the ktlint jar. Closes #2550
Goooler
approved these changes
Feb 20, 2024
ktlint-cli/src/main/kotlin/com/pinterest/ktlint/cli/internal/KtlintCommandLine.kt
Outdated
Show resolved
Hide resolved
|
|
||
| data class PatternsFromStdin( | ||
| val delimiter: String, | ||
| ) : StdinOption() |
ktlint-cli/src/main/kotlin/com/pinterest/ktlint/cli/internal/KtlintCommandLine.kt
Outdated
Show resolved
Hide resolved
|
One more thing, this PR needs a rebase to drop 6ff4d8a. |
Clikt is a kotlin library which allows more Kotlin native code. Also, it is blocking minifying the ktlint jar. Closes #2550
# Conflicts: # ktlint-cli/src/main/kotlin/com/pinterest/ktlint/cli/internal/KtlintCommandLine.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Clikt is a kotlin library which allows more Kotlin native code. Also, it is blocking minifying the ktlint jar.
Closes #2550
Checklist
Before submitting the PR, please check following (checks which are not relevant may be ignored):
Closes #<xxx>orFixes #<xxx>(replace<xxx>with issue number)Documentation is updated. See difference between snapshot and release documentation