Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rule blank-line-between-when-conditions #2564

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

paul-dingemans
Copy link
Collaborator

Description

Add rule blank-line-between-when-conditions.

Depending on .editorconfig property ij_kotlin_line_break_after_multiline_when_entry blank lines are added between all when-entries in a when-statement if the statement contains at least one multiline when-entry.

Simple when-statements (e.g. all when-entries are single line) then blank lines between the when-entries are removed (regardless of ij_kotlin_line_break_after_multiline_when_entry)

Closes #2533

Checklist

Before submitting the PR, please check following (checks which are not relevant may be ignored):

  • Commit message are well written. In addition to a short title, the commit message also explain why a change is made.
  • At least one commit message contains a reference Closes #<xxx> or Fixes #<xxx> (replace<xxx> with issue number)
  • Tests are added
  • KtLint format has been applied on source code itself and violations are fixed
  • PR title is short and clear (it is used as description in the release changelog)
  • PR description added (background information)

Documentation is updated. See difference between snapshot and release documentation

  • Snapshot documentation in case documentation is to be released together with a code change
  • Release documentation in case documentation is related to a released version of ktlint and has to be published as soon as the change is merged to master

@paul-dingemans paul-dingemans added this to the 1.2 milestone Feb 24, 2024
@paul-dingemans paul-dingemans merged commit 60b6b8f into master Feb 27, 2024
22 checks passed
@paul-dingemans paul-dingemans deleted the 2533-blank-line-after-when-condition branch February 27, 2024 08:26
@paul-dingemans paul-dingemans changed the title 2533 blank line after when condition Add rule blank-line-between-when-conditions Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Insert blank lines for when statement branches
1 participant