Fixed [{ }] notation for issue #2675 #2677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng rule. Added tests.
|
Tnx for reporting and fixing. I made some small changes from consistency viewpoint. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2675
Description
Fixes the erroneous error for notations like
[{ }], as described in the issue.The
}]case was already handled by #596, but the[{notation needed some additional fix. There was a special exception for({, and since this one is similar, I added the case for LBRACKET too.Two tests were added, one to check that notations like
[{ a -> a }],[{ }], and[{}]are allowed, and a second one to check that[ { } ]is formatted correctly.