Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass client to base method from entity create @classmethod #112

Merged
merged 2 commits into from
Jul 19, 2023

Conversation

rushabhvaria
Copy link
Member

This PR fixes entity create methods as previously users were unable to pass SDK clients from the class to the base model create method.

@rushabhvaria rushabhvaria added the bug Something isn't working label Jul 19, 2023
@rushabhvaria rushabhvaria self-assigned this Jul 19, 2023
@rushabhvaria rushabhvaria temporarily deployed to integ July 19, 2023 16:48 — with GitHub Actions Inactive
@rushabhvaria rushabhvaria temporarily deployed to integ July 19, 2023 16:48 — with GitHub Actions Inactive
@rushabhvaria rushabhvaria temporarily deployed to integ July 19, 2023 19:35 — with GitHub Actions Inactive
@rushabhvaria rushabhvaria temporarily deployed to integ July 19, 2023 19:35 — with GitHub Actions Inactive
@rushabhvaria rushabhvaria merged commit 929027c into main Jul 19, 2023
6 checks passed
@rushabhvaria rushabhvaria deleted the bug-fix/add-client-to-entity-create-classmethods branch July 19, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG - Inconsistent usage of client in cls._create method for Audience and CustomerList objects
2 participants