Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ad group and conversion events integration tests #113

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Fix ad group and conversion events integration tests #113

merged 1 commit into from
Jul 19, 2023

Conversation

rushabhvaria
Copy link
Member

  • Change ad group targeting from MALE to male due to spec changes
  • Change conversion event response due to spec changes and assert error message when request fails

@rushabhvaria rushabhvaria added the testing Issue affects testing label Jul 19, 2023
@rushabhvaria rushabhvaria self-assigned this Jul 19, 2023
@rushabhvaria rushabhvaria temporarily deployed to integ July 19, 2023 17:07 — with GitHub Actions Inactive
@rushabhvaria rushabhvaria temporarily deployed to integ July 19, 2023 17:07 — with GitHub Actions Inactive
@rushabhvaria rushabhvaria temporarily deployed to integ July 19, 2023 17:07 — with GitHub Actions Inactive
@rushabhvaria rushabhvaria merged commit f48ced9 into main Jul 19, 2023
6 checks passed
@rushabhvaria rushabhvaria deleted the fix/ad-group-and-tag-integ-tests branch July 19, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfana01 dfana01 dfana01 approved these changes

Assignees

@rushabhvaria rushabhvaria

Labels
testing Issue affects testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rushabhvaria @dfana01